Re: [PATCH v3 3/4] staging: rtl8723bs: use ether_addr_copy() in rtw_macaddr_cfg()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-06-27 at 19:14 +0300, Andy Shevchenko wrote:
> On Wed, Jun 27, 2018 at 4:11 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > On Wed, Jun 27, 2018 at 02:56:00PM +0200, Michael Straube wrote:
> > > Should I add a thanks line to the commit message:
> > > 
> > >     Thanks to Dan Carpenter, Joe Perches and Andy Shevchenko.
> > > 
> > > Or would that be considered as too much?
> > 
> > You can write whatever the heck you want...  :P  No one cares.

I hope that's true.

> > When it comes to credit, I do appreciate Reported-by tags because LWN
> > and employers do count those sometimes.

Which is likely as useful as judging engineer
productivity by LOC counts.

> In some cases Suggested-by fits better.

True, but meh.

I think all the Suggested-by, Reported-by,
Co-developed-by and such are mostly unnecessary.

Who really cares for anything other than
signed-off-by, acked-by, tested-by, and
maybe reviewed-by ?

Maybe the kernel should add a signature for
"Co-authored-by:" instead of "Co-developed-by:"

Perhaps another option would be to extend
the git commit "Author:" attribute to allow
multiple names and addresses.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux