On Fri, Jun 01, 2018 at 11:31:22AM -0700, rkir@xxxxxxxxxx wrote:
> From: Yu Ning <yu.ning@xxxxxxxxx>
>
> Besides adding ACPI bindings to the goldfish audio driver, modify the
> ACPI driver to inform it that the driver is a platform device.
>
> Signed-off-by: Yu Ning <yu.ning@xxxxxxxxx>
> Signed-off-by: Roman Kiryanov <rkir@xxxxxxxxxx>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
I see no modification of an "ACPI driver" here :(
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index 2bec3205326e..87ebeb770e87 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -28,6 +28,7 @@
> #include <linux/uaccess.h>
> #include <linux/slab.h>
> #include <linux/goldfish.h>
> +#include <linux/acpi.h>
>
> MODULE_AUTHOR("Google, Inc.");
> MODULE_DESCRIPTION("Android QEMU Audio Driver");
> @@ -368,12 +369,19 @@ static const struct of_device_id goldfish_audio_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, goldfish_audio_of_match);
>
> +static const struct acpi_device_id goldfish_audio_acpi_match[] = {
> + { "GFSH0005", 0 },
> + { },
> +};
> +MODULE_DEVICE_TABLE(acpi, goldfish_audio_acpi_match);
> +
> static struct platform_driver goldfish_audio_driver = {
> .probe = goldfish_audio_probe,
> .remove = goldfish_audio_remove,
> .driver = {
> .name = "goldfish_audio",
> .of_match_table = goldfish_audio_of_match,
> + .acpi_match_table = ACPI_PTR(goldfish_audio_acpi_match),
> }
> };
>
What platform device?
confused,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
