Hi Dan, thank you for your comments, I am going to update all patches to include "staging: goldfish: " and to replace macros with functions. Regards, Roman. On Fri, Jun 1, 2018 at 1:09 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > These need a subsystem prefix in the subject line: > > [PATCH 1/3] staging: goldfish: Fix checkpatch warnings in goldfish_audio.c > > On Thu, May 31, 2018 at 05:22:21PM -0700, rkir@xxxxxxxxxx wrote: > > -#define AUDIO_READ(data, addr) (readl(data->reg_base + addr)) > > -#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr)) > > +#define AUDIO_READ(data, addr) (readl((data)->reg_base + (addr))) > > +#define AUDIO_WRITE(data, addr, x) (writel(x, (data)->reg_base + (addr))) > > #define AUDIO_WRITE64(data, addr, addr2, x) \ > > - (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2)) > > + (gf_write_dma_addr((x), (data)->reg_base + (addr), \ > > + (data)->reg_base + (addr2))) > > It's probably better to just make these functions. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
