Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> writes: >> + } else { >> + err = br_switchdev_port_obj_add(dev, v->vid, flags); >> + if (err && err != -EOPNOTSUPP) >> + goto out; >> } > > Except that br_switchdev_port_obj_add taking vid and flags arguments > seems confusing to me, the change looks good: I'm not sure what you're aiming at. Both VID and flags are sent with the notification, so they need to be passed on to the function somehow. Do you have a counterproposal for the API? Thanks, Petr _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel