A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge port or a bridge. Signed-off-by: Petr Machata <petrm@xxxxxxxxxxxx> --- net/bridge/br_vlan.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index a75fe930..14c1b6c 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c @@ -268,6 +268,10 @@ static int __vlan_add(struct net_bridge_vlan *v, u16 flags) goto out_filt; v->brvlan = masterv; v->stats = masterv->stats; + } else { + err = br_switchdev_port_obj_add(dev, v->vid, flags); + if (err && err != -EOPNOTSUPP) + goto out; } /* Add the dev mac and count the vlan only if it's usable */ @@ -303,6 +307,8 @@ static int __vlan_add(struct net_bridge_vlan *v, u16 flags) br_vlan_put_master(masterv); v->brvlan = NULL; } + } else { + br_switchdev_port_obj_del(dev, v->vid); } goto out; @@ -328,6 +334,11 @@ static int __vlan_del(struct net_bridge_vlan *v) err = __vlan_vid_del(p->dev, p->br, v->vid); if (err) goto out; + } else { + err = br_switchdev_port_obj_del(v->br->dev, v->vid); + if (err && err != -EOPNOTSUPP) + goto out; + err = 0; } if (br_vlan_should_use(v)) { @@ -605,6 +616,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags, bool *changed) vg->num_vlans++; *changed = true; } + ret = br_switchdev_port_obj_add(br->dev, vid, flags); + if (ret && ret != -EOPNOTSUPP) + return ret; if (__vlan_add_flags(vlan, flags)) *changed = true; -- 2.4.11 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel