On Tue, May 15, 2018 at 11:01:20AM +1000, NeilBrown wrote: > On Mon, May 14 2018, Sergio Paracuellos wrote: > > > The following patch series fix all remaining checkpatch complains > > about this driver. Changes have not been tested and also compiled > > but it should not have any problem about them. > > Thanks for these. As you say, nothing in them could change behaviour of > the driver, but I tested them anyway and gpio still works (both in and > out) - no surprises. Thanks for testing this and review. > > I can give > Reviewed-by: NeilBrown <neil@xxxxxxxxxx> > for all exect "dt-bindings: gpio: add documentation for mt7621-gpio". > I'll reply to the separately. I have just sent v2 for all of this series and also replied to your comments separately. Hope this helps. > > Of course the dt-binding patches will need broader review once they seem > ready to us. > > Thanks, > NeilBrown Best regards, Sergio Paracuellos > > > > > > Sergio Paracuellos (5): > > staging: mt7621-gpio: fix some warnings because of lines exceded 80 > > characters > > staging: mt7621-gpio: add SPDX identifier > > dt-bindings: add compatible string for 'mtk' MediaTek > > dt-bindings: gpio: add documentation for mt7621-gpio > > staging: mt7621-gpio: remove device tree related stuff from TODO file > > > > .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51 ++++++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > drivers/staging/mt7621-gpio/TODO | 1 - > > drivers/staging/mt7621-gpio/gpio-mt7621.c | 24 +++++----- > > 4 files changed, 66 insertions(+), 11 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt > > > > -- > > 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel