On Tue, May 15, 2018 at 11:26:38AM +1000, NeilBrown wrote:
> On Mon, May 14 2018, Sergio Paracuellos wrote:
>
> > Documentation related with device tree and its checkpatch complains
> > have been added. Update TODO file accordingly.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> > drivers/staging/mt7621-gpio/TODO | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
> > index 7143905..492dbaa 100644
> > --- a/drivers/staging/mt7621-gpio/TODO
> > +++ b/drivers/staging/mt7621-gpio/TODO
> > @@ -1,5 +1,4 @@
> >
> > - general code review and clean up
> > -- ensure device-tree requirements are documented
> >
> > Cc: NeilBrown <neil@xxxxxxxxxx>
> > --
> > 2.7.4
>
> I said before that I could give a reviewed-by for this, but obviously I
> cannot as it depend on the bindings documentation which I didn't
> approve.
>
> However, it does look like I need to add things to the list.
> Apart from making sure interrupts work, the only thing I see in the code
> is various global variables (mediatek_gpio_membase, mediatek_gpio_irq,
> mediatek_gpio_irq_domain, gc_map) which should probably be in a
> drvdata allocated structure (stored with platform_set_drvdata() -
> plenty of examples in drivers/gpio/gpio-*.c)
> I think it would then be ready for submission to drivers/gpio
> and linux-gpio@xxxxxxxxxxxxxxx.
Ack! I have just update TODO with this stuff in v2 series.
>
> Thanks,
> NeilBrown
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
