Hi Richard and Dan, > -----Original Message----- > From: Richard Cochran [mailto:richardcochran@xxxxxxxxx] > Sent: Saturday, April 21, 2018 1:31 PM > To: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Cc: Y.b. Lu <yangbo.lu@xxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx; Greg > Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver > > On Sat, Apr 21, 2018 at 07:41:35AM +0300, Dan Carpenter wrote: > > On Fri, Apr 20, 2018 at 02:01:25PM -0700, Richard Cochran wrote: > > > On Thu, Apr 19, 2018 at 01:40:08PM +0300, Dan Carpenter wrote: > > > > This driver seems nice and so far as I can see it doesn't need to > > > > be in staging once we get the other parts merged. > > > > > > Please explain how this unit ties in with the MAC units. > > > > > > > I have no idea. I assumed there were some dependencies which > > prevented this code from being merged into the normal part of the > > kernel. From what I can see the code looks nice so if there aren't > > dependencies then we should put it in the normal part instead of in staging. > > My question is really for Yangbo... > > If the driver can't work without out-of-tree hacks, then it shouldn't be merged > (but I wouldn't object in that case for inclusion in staging just so users can > integrate it). > > So we need to understand how this clock driver will be connected to the time > stamping MAC drivers. [Y.b. Lu] Sorry for forgetting to explain that. Actually I will send the timestamping support patch for drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c. Since the 1588 timer module had been initialized in MC firmware, the timestamping support and the clock driver will not depend on each other in code. I'm not sure whether it's proper to put this driver in staging/fsl-dpaa2/, but the rtc is the component of dpaa2. Hope your suggestion where we should put it, where is the normal part? Thank you very much. > > Thanks, > Richard _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
