On 22/03/18 12:27, Jian Zhang wrote:
This is a patch to the cb_pcidas64.c file that fixes up a multiple line dereference warning found by the checkpatch.pl tool
Signed-off-by: Jian Zhang <kernel@xxxxxxxxxxxxxx>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index ceef9058b59f..77099f177516 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2464,18 +2464,15 @@ static int setup_channel_queue(struct comedi_device *dev,
for (i = 0; i < cmd->chanlist_len; i++) {
Could I suggest setting a local variable here? :
unsigned int chanspec = cmd->chanlist[i];
bits = 0;
/* set channel */
- bits |= adc_chan_bits(CR_CHAN(cmd->
- chanlist[i]));
+ bits |= adc_chan_bits(
+ CR_CHAN(cmd->chanlist[i]));
/* set gain */
- bits |= ai_range_bits_6xxx(dev,
- CR_RANGE(cmd->
- chanlist
- [i]));
+ bits |= ai_range_bits_6xxx(
+ dev, CR_RANGE(cmd->chanlist[i]));
/* set single-ended / differential */
- bits |= se_diff_bit_6xxx(dev,
- CR_AREF(cmd->
- chanlist[i]) ==
- AREF_DIFF);
+ bits |= se_diff_bit_6xxx(
+ dev,
+ CR_AREF(cmd->chanlist[i]) == AREF_DIFF);
if (CR_AREF(cmd->chanlist[i]) == AREF_COMMON)
bits |= ADC_COMMON_BIT;
/* mark end of queue */
Then just replace `cmd->chanlist[i]` with `chanspec` in the above
statements, and line the arguments up with the opening parentheses as
they were before. For example, replace `CR_CHAN(cmd->chanlist[i])` with
`CR_CHAN(chanspec)`. That should make the code formatting a bit neater.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
