Re: [PATCH] Staging: comedi: fix multiple line dereference coding style issue in cb_pcidas64.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 22, 2018 at 08:27:28PM +0800, Jian Zhang wrote:
> This is a patch to the cb_pcidas64.c file that fixes up a multiple line dereference warning found by the checkpatch.pl tool

Please properly wrap your changelog comments at 72 columns, like your
editor tried to force you to do :)

> 
> Signed-off-by: Jian Zhang <kernel@xxxxxxxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 17 +++++++----------
>  1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index ceef9058b59f..77099f177516 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2464,18 +2464,15 @@ static int setup_channel_queue(struct comedi_device *dev,
>  			for (i = 0; i < cmd->chanlist_len; i++) {
>  				bits = 0;
>  				/* set channel */
> -				bits |= adc_chan_bits(CR_CHAN(cmd->
> -							      chanlist[i]));
> +				bits |= adc_chan_bits(
> +					CR_CHAN(cmd->chanlist[i]));
>  				/* set gain */
> -				bits |= ai_range_bits_6xxx(dev,

No need to change this line.

> -							   CR_RANGE(cmd->
> -								    chanlist
> -								    [i]));
> +				bits |= ai_range_bits_6xxx(
> +					dev, CR_RANGE(cmd->chanlist[i]));
>  				/* set single-ended / differential */
> -				bits |= se_diff_bit_6xxx(dev,
> -							 CR_AREF(cmd->
> -								 chanlist[i]) ==
> -							 AREF_DIFF);
> +				bits |= se_diff_bit_6xxx(
> +					dev,

No need to change this line, right?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux