Re: [PATCH] Staging: comedi: Add MODULE_AUTHOR and similar to ni_pcimio.c.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/01/11 02:03, Greg KH wrote:
> On Thu, Jan 27, 2011 at 06:52:15PM -0500, W. Trevor King wrote:
>> Without this metadata, I got (while running 2.6.36)
>>   # modprobe ni_pcimio
>>   FATAL: Error inserting ni_pcimio (/.../ni_pcimio.ko):
>>     Unknown symbol in module, or unknown parameter (see dmesg)
>>   # dmesg | tail -n30
>>   ...
>>   [ 2970.180691] ni_pcimio: Unknown symbol ni_tio_handle_interrupt (err 0)
>>   [ 2970.181170] ni_pcimio: Unknown symbol ni_tio_set_mite_channel (err 0)
>>   [ 2970.183127] ni_pcimio: Unknown symbol ni_tio_init_counter (err 0)
>>   [ 2970.183562] ni_pcimio: Unknown symbol ni_tio_winsn (err 0)
>>   (similar missing symbols)
>>   ...
>> Even though other Comedi modules were providing the symbols:
>>   # grep ni_tio_handle_interrupt /proc/kallsyms
>>   d82a45b1 t ni_tio_handle_interrupt      [ni_tiocmd]
> 
> Odds are you didn't run 'depmod' after installing the kernel then,
> right?
> 
>> With the metadata macros, ni_pcimio loads successfully.
> 
> I don't see how that would work a all.  I'm not saying that this is an
> incorrect patch, but that it shouldn't solve a module dependancy
> problem.
> 
> thanks,
> 
> greg k-h

Some of the symbols it tries to import are exported GPL-only (e.g.
'comedi_pci_auto_config'), so perhaps that's why.  Apparently it used to
work in 2.6.35 (though I haven't confirmed this myself yet), so I guess
something got fixed.

You can drop this patch if you want, as I'm planning to submit a
replacement for this patch that adds license information to all the NI
comedi drivers that don't have it already.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux