[PATCH] Staging: comedi: Add MODULE_AUTHOR and similar to ni_pcimio.c.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Without this metadata, I got (while running 2.6.36)
  # modprobe ni_pcimio
  FATAL: Error inserting ni_pcimio (/.../ni_pcimio.ko):
    Unknown symbol in module, or unknown parameter (see dmesg)
  # dmesg | tail -n30
  ...
  [ 2970.180691] ni_pcimio: Unknown symbol ni_tio_handle_interrupt (err 0)
  [ 2970.181170] ni_pcimio: Unknown symbol ni_tio_set_mite_channel (err 0)
  [ 2970.183127] ni_pcimio: Unknown symbol ni_tio_init_counter (err 0)
  [ 2970.183562] ni_pcimio: Unknown symbol ni_tio_winsn (err 0)
  (similar missing symbols)
  ...
Even though other Comedi modules were providing the symbols:
  # grep ni_tio_handle_interrupt /proc/kallsyms
  d82a45b1 t ni_tio_handle_interrupt      [ni_tiocmd]

With the metadata macros, ni_pcimio loads successfully.

Signed-off-by: W. Trevor King <wking@xxxxxxxxxx>
---
 drivers/staging/comedi/drivers/ni_pcimio.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c b/drivers/staging/comedi/drivers/ni_pcimio.c
index 23a3812..dc0548c 100644
--- a/drivers/staging/comedi/drivers/ni_pcimio.c
+++ b/drivers/staging/comedi/drivers/ni_pcimio.c
@@ -1277,6 +1277,11 @@ static void __exit driver_pcimio_cleanup_module(void)
 module_init(driver_pcimio_init_module);
 module_exit(driver_pcimio_cleanup_module);
 
+MODULE_AUTHOR("Comedi http://www.comedi.org";);
+MODULE_DESCRIPTION("Comedi driver for NI PCI-MIO-E series and M series");
+MODULE_LICENSE("GPL");
+
+
 struct ni_private {
 NI_PRIVATE_COMMON};
 #define devpriv ((struct ni_private *)dev->private)
-- 
1.7.3.1.104.gc752e

Git branch at
  http://www.physics.drexel.edu/~wking/code/git/linux-2.6.staging.git

-- 
This email may be signed or encrypted with GPG (http://www.gnupg.org).
The GPG signature (if present) will be attached as 'signature.asc'.
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

My public key is at http://www.physics.drexel.edu/~wking/pubkey.txt

Attachment: pgp8Rm7Qc2K1D.pgp
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux