On Fri, Mar 9, 2018 at 10:11 AM, Eric Anholt <eric@xxxxxxxxxx> wrote: > "Tobin C. Harding" <me@xxxxxxxx> writes: > >> The kernel would like to have all stack VLA usage removed[1]. The >> array here is fixed (declared with a const variable) but it appears >> like VLA to the compiler. We can use a pre-processor define to quiet >> the compiler. >> >> [1]: https://lkml.org/lkml/2018/3/7/621 >> >> Signed-off-by: Tobin C. Harding <me@xxxxxxxx> >> --- >> >> The name of this constant may need changing, there is already a >> pre-processor constant VCHIQ_MAX_SERVICES > > Maybe just use ARRAY_SIZE(local_max_services) and not have the #define? I think you mean ARRAY_SIZE(service_data) ? In that case, yeah, it seems like a raw "64" for the array size can be used instead. -Kees -- Kees Cook Pixel Security _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
