On 02/16/2018 10:49 PM, Greg KH wrote: > On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote: >> >> >> On 02/16/2018 04:46 PM, Greg KH wrote: >>> On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote: >>>> Current ion kernel mapping implementation uses vmap() to map previously >>>> allocated buffers into kernel virtual address space. >>>> >>>> On 32-bit platforms, vmap() might fail on large enough buffers due to the >>>> limited available vmalloc space. dma_buf_kmap() should guarantee that >>>> only one page is mapped at a time. >>>> >>>> To fix this, kmap()/kmap_atomic() is used to implement the appropriate >>>> interfaces. >>>> >>>> Signed-off-by: Alexey Skidanov <alexey.skidanov@xxxxxxxxx> >>> >>> Again, I said I required another intel.com signed-off-by on any of your >>> ion patches before I would take them. Please get internal review first >>> before asking for review from the community. >>> >>> greg k-h >>> Is there any issue with this patch? > > Given that no other Intel developer reviewed it, I don't know. Again, > use the resources you have, to ignore that is folly. > > greg k-h > I try to improve the current ion implementation by fixing the existing (potential) bugs. If it's rejected even without being reviewed - probably it doesn't make sense to continue ... BTW, it has been reviewed internally ... Alexey _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
