Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 16, 2018 at 10:43:03PM +0200, Alexey Skidanov wrote:
> 
> 
> On 02/16/2018 04:46 PM, Greg KH wrote:
> > On Tue, Feb 13, 2018 at 12:33:53AM +0200, Alexey Skidanov wrote:
> >> Current ion kernel mapping implementation uses vmap() to map previously
> >> allocated buffers into kernel virtual address space.
> >>
> >> On 32-bit platforms, vmap() might fail on large enough buffers due to the
> >> limited available vmalloc space. dma_buf_kmap() should guarantee that
> >> only one page is mapped at a time.
> >>
> >> To fix this, kmap()/kmap_atomic() is used to implement the appropriate
> >> interfaces.
> >>
> >> Signed-off-by: Alexey Skidanov <alexey.skidanov@xxxxxxxxx>
> > 
> > Again, I said I required another intel.com signed-off-by on any of your
> > ion patches before I would take them.  Please get internal review first
> > before asking for review from the community.
> > 
> > greg k-h
> > Is there any issue with this patch?

Given that no other Intel developer reviewed it, I don't know. Again,
use the resources you have, to ignore that is folly.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux