Also the patch prefix is wrong in the email subject. It should say, [PATCH] staging: rtl8723bs: Resolve RF Type mismatch On Wed, Feb 07, 2018 at 01:31:48AM +0900, Kangmin Park wrote: > Oops, Sorry for being stupid cuz of first time to use git email. No problem. We were all newbies once. Send the email to yourself first and try applying it with `git am`, then review the patch with `git log -p`. > RF_TYPE and ODM_RF_TYPE on staging/rtl8723bs is different from > staging/rtlwifi 's - updated from v 4.14 - > So, I try to update code on staging/rtl8723bs in comparison with > staging/rtlwifi. > commit message is "Update rf_type and odm_rf_type in comparison with > drivers/staging/rtlwifi" It needs a longer commit message than this. Also it probably needs to be tested. I tried for about 10 seconds to find which patch you were referring that updated staging/rtlwifi but I gave up. What is the git hash and subject? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel