Re: [PATCH] Resolve RF Type mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m@xxxxxxxxx>

No changelog, no sign-off.  Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.

This patch has unrelated white space changes as well.  Here is how the
rules work:

> -	ODM_1T1R	=	0,
> +	ODM_1T1R		=	0,

This are unrelated.

This white space change is on the same line so that's fine (it's
related).

> -	else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> +	else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux