On Sun, Jan 28, 2018 at 12:41:25PM -0600, Larry Finger wrote: > On 01/28/2018 08:05 AM, Erik Liodden wrote: > > Add identifier names to function definition arguments to comply with > > the kernel coding style and the naming convention in the rest of the > > file. > > > > Issues found by checkpatch. > > > > Signed-off-by: Erik Liodden <erik.liodden@xxxxxxxxx> > > --- > > As far as I am concerned, this patch is merely churning the source. Those > prototypes correctly describe the calling sequence to the compiler, which is > all that is necessary. Checkpatch is a moving specification. These were NOT > ERRORS/WARNINGS/CHECKS when this code was first introduced. Why should it be > made to conform to it now? Because it's still in staging... The checkpatch rule is new but it's sort of been an unwritten rule for almost two decades. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
