Re: [PATCH] staging: rtlwifi: add identifier names to function definition arguments

[Larry Finger <Larry.Finger@xxxxxxxxxxxx>]

On 01/28/2018 08:05 AM, Erik Liodden wrote:
> Add identifier names to function definition arguments to comply with
> the kernel coding style and the naming convention in the rest of the
> file.
>
> Issues found by checkpatch.
>
> Signed-off-by: Erik Liodden <erik.liodden@xxxxxxxxx>
> ---

As far as I am concerned, this patch is merely churning the source. Those 
prototypes correctly describe the calling sequence to the compiler, which is all 
that is necessary. Checkpatch is a moving specification. These were NOT 
ERRORS/WARNINGS/CHECKS when this code was first introduced. Why should it be 
made to conform to it now? Besides, you should use checkpatch in an advisory role.

NACK.

Larry

>   drivers/staging/rtlwifi/wifi.h | 29 +++++++++++++++--------------
>   1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h
> index ca0243f..a23bb17 100644
> --- a/drivers/staging/rtlwifi/wifi.h
> +++ b/drivers/staging/rtlwifi/wifi.h
> @@ -2379,16 +2379,17 @@ struct rtl_hal_usbint_cfg {
>   	u32 rx_max_size;
>   
>   	/* op - rx */
> -	void (*usb_rx_hdl)(struct ieee80211_hw *, struct sk_buff *);
> -	void (*usb_rx_segregate_hdl)(struct ieee80211_hw *, struct sk_buff *,
> -				     struct sk_buff_head *);
> +	void (*usb_rx_hdl)(struct ieee80211_hw *hw, struct sk_buff *skb);
> +	void (*usb_rx_segregate_hdl)(struct ieee80211_hw *hw,
> +				     struct sk_buff *skb,
> +				     struct sk_buff_head *skbh);
>   
>   	/* tx */
> -	void (*usb_tx_cleanup)(struct ieee80211_hw *, struct sk_buff *);
> -	int (*usb_tx_post_hdl)(struct ieee80211_hw *, struct urb *,
> -			       struct sk_buff *);
> -	struct sk_buff *(*usb_tx_aggregate_hdl)(struct ieee80211_hw *,
> -						struct sk_buff_head *);
> +	void (*usb_tx_cleanup)(struct ieee80211_hw *hw, struct sk_buff *skb);
> +	int (*usb_tx_post_hdl)(struct ieee80211_hw *hw, struct urb *urb,
> +			       struct sk_buff *skb);
> +	struct sk_buff *(*usb_tx_aggregate_hdl)(struct ieee80211_hw *hw,
> +						struct sk_buff_head *skbh);
>   
>   	/* endpoint mapping */
>   	int (*usb_endpoint_mapping)(struct ieee80211_hw *hw);
> @@ -2693,12 +2694,12 @@ struct rtl_btc_ops {
>   };
>   
>   struct rtl_halmac_ops {
> -	int (*halmac_init_adapter)(struct rtl_priv *);
> -	int (*halmac_deinit_adapter)(struct rtl_priv *);
> -	int (*halmac_init_hal)(struct rtl_priv *);
> -	int (*halmac_deinit_hal)(struct rtl_priv *);
> -	int (*halmac_poweron)(struct rtl_priv *);
> -	int (*halmac_poweroff)(struct rtl_priv *);
> +	int (*halmac_init_adapter)(struct rtl_priv *rtlpriv);
> +	int (*halmac_deinit_adapter)(struct rtl_priv *rtlpriv);
> +	int (*halmac_init_hal)(struct rtl_priv *rtlpriv);
> +	int (*halmac_deinit_hal)(struct rtl_priv *rtlpriv);
> +	int (*halmac_poweron)(struct rtl_priv *rtlpriv);
> +	int (*halmac_poweroff)(struct rtl_priv *rtlpriv);
>   
>   	int (*halmac_phy_power_switch)(struct rtl_priv *rtlpriv, u8 enable);
>   	int (*halmac_set_mac_address)(struct rtl_priv *rtlpriv, u8 hwport,

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel