Re: [PATCH v3 2/3] staging: xgifb: vb_setmode: fix long line warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 12, 2018 at 09:23:08AM -0700, Kenny Ballou wrote:
> Fix a number of checkpatch warnings in xgfib/vb_setmode.c about line
> length being over 80 characters.
> 
> Signed-off-by: Kenny Ballou <kballou@xxxxxxxxxxxxxx>
> ---
> @@ -714,7 +715,9 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
>  	data &= 0x7F;
>  	xgifb_reg_set(pVBInfo->P3d4, 0x11, data); /* Unlock CRTC */
>  	xgifb_reg_set(pVBInfo->P3d4, 0x01, (unsigned short)(tempcx & 0xff));
> -	xgifb_reg_and_or(pVBInfo->P3d4, 0x0b, ~0x0c,
> +	xgifb_reg_and_or(pVBInfo->P3d4,
> +			 0x0b,
> +			 0x0c,
>  			 (unsigned short)((tempcx & 0x0ff00) >> 10));

1) You've removed the ~ from ~0xc.  2)  This is not a 80 character
defect (see your patch description, the patch doesn't match the
description).  3)  The original style is prefered.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux