On 12/20/2017 12:42 PM, Greg KH wrote: > On Wed, Dec 20, 2017 at 10:26:49AM +0000, Laurentiu Tudor wrote: >> On 12/19/2017 06:10 PM, Greg KH wrote: >>>>> But all of these .h files are only used by the code in this specific >>>>> directory, no where else. >>>> >>>> They are also used by our ethernet driver, see: >>>> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h >>> >>> Ick, really? Then they should not be buried in a bus-specific >>> location, but rather be in include/linux/SOMEWHERE, right? >> >> Right. The goal is that in the end, all headers be moved to the already >> existing include/linux/fsl/. For now I've left these in staging because >> they are not part of the bus "core" infrastructure. > > Then shouldn't they be in the drivers/staging/fsl-mc/include/ directory > now to show this? Not sure i get your comment. Aren't we talking about the headers in there? This was your original comment: > Also, what's up with the .h files in drivers/staging/fsl-bus/include? > You didn't touch those with this movement, right? Why? --- Best Regards, Laurentiu _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel