On Wed, Nov 29, 2017 at 12:08:44PM +0200, laurentiu.tudor@xxxxxxx wrote: > From: Stuart Yoder <stuart.yoder@xxxxxxx> > > Move the source files out of staging into their final locations: > -include files in drivers/staging/fsl-mc/include go to include/linux/fsl > -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip > -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc > -README.txt, providing and overview of DPAA goes to > Documentation/dpaa2/overview.txt > > Update or delete other remaining staging files-- Makefile, Kconfig, TODO. > Update dpaa2_eth and dpio staging drivers. > > Signed-off-by: Stuart Yoder <stuyoder@xxxxxxxxx> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx> > [Laurentiu: rebased, add dpaa2_eth and dpio #include updates] > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Jason Cooper <jason@xxxxxxxxxxxxxx> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx> > --- > Notes: > -v4: > - regenerated patch with renames detection disabled (Andrew Lunn) > -v3: > - rebased Ok, meta-comments on the structure of the code. You have 8 .h files that are "private" to your bus logic. That's 7 too many, some of them have a bigger license header than actual content :) Please consolidate into 1. Also, the headers should be moved to SPDX format to get rid of the boilerplate. I _think_ it's BSD/GPL, right? Hard to tell :( Your "public" .h file does not need to go into a subdirectory, just name it fsl-mc.h and put it in include/linux/. One comment on the fields in your .h file, all of the user/kernel crossing boundry structures need to use the "__" variant of types, like "__u8" and the like. You mix and match them for some reason, you need to be consistent. Also, what's up with the .h files in drivers/staging/fsl-bus/include? You didn't touch those with this movement, right? Why? For this initial move, only move the bus "core" code out, not the other stuff like: > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 119 +++ these should be a separate file move, right? > drivers/staging/fsl-dpaa2/ethernet/README | 2 +- Why does a README file for a different driver need to be touched? > drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- > drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 +- > drivers/staging/fsl-mc/README.txt | 386 --------- This file gets moved to the Documentation directory, yet it is not tied into the documentation build process, that's not good. It doesn't need to have a separate directory either, right? And speaking of documentation, you have directories in sysfs, yet no Documentation/ABI/ files describing them. Please fix that up. that's a good start :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
