Hi Gilad & Tobin, > > Perhaps, if Stephen is willing, re-write the code to be more readable > > by, for example, using a temp > > variable for the register address, and in doing so both making the > > code more readable as well as > > treating the symptom? I'm definitely willing; however, I don't know the hardware, so I'm already off to a bad start with questions like "which integer type is appropriate for the register address?" > Oh, refactoring, that's a whole 'nother story. I'm a huge fan. And I agree with you that that is the > correct way to deal with 'line over 80' warnings. For me, it helped to get a few _trivial_ > checkpatch fixes in before I moved onto refactoring. 'line over 80' warnings are great to fix if > viewed as an opportunity to refactor but not so great if viewed as a trivial white space fix to get > started with. I think this makes the most sense right now. A pure trivial change is what I'd like, to help get some experience with the development process and working with the community. I'll look for something else (hopefully within the same staging driver, since you've all been super welcoming) and submit a patch for it. Hopefully I'll circle back for some slightly less trivial refactors after that! Thanks for your feedback! Stephen _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
