Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote:
> Simply break down some long lines and tab-indent them.

Hi Stephen,

Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see
success fixing 'line over 80' warnings. There are a bunch of arguments for and against the line over
80 limit, a web search will surely show them to you. The TL;DR is that it these changes do not
_really_ improve the readability of the code, they are just changes to quiet the static analysis
tool.

There are a bunch of other white space fixes that are more beneficial, perhaps you could wet your
feet with these (incorrect placement of parenthesis for example).

Good luck,
Tobin.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux