RE: Two rtlwifi drivers?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Kalle Valo [mailto:kvalo@xxxxxxxxxxxxxx]
> Sent: Monday, October 16, 2017 9:23 PM
> To: Pkshih
> Cc: Larry Finger; Greg Kroah-Hartman; Dan Carpenter; 莊彥宣; Johannes Berg; Souptick Joarder;
> devel@xxxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: Re: Two rtlwifi drivers?
> 
> Hi PK,
> 
> you got good answers already so only short reply from me:
> 
> Pkshih <pkshih@xxxxxxxxxxx> writes:
> 
> > 3) Coming drivers -- rtl8723de and rtl8821ce
> >    We're developing the two drivers, and rtl8723de and rtl8821ce will
> >    be ready on 2017Q4 and 2018Q1 respectively. The drivers are based on
> >    rtl8822be that in staging now, so the line of code will be fewer.
> >    The new files will be a new IC folder and IC supported files of
> >    three modules that btcoexist, phydm and halmac. Could I submit
> >    them to wirless tree when they're ready?
> 
> My recommendation is to avoid accumulating patches at all cost and start
> submitting them as soon as you can. This way you get patches committed
> much more smoother. So do not wait until _all_ patches are ready,
> instead start submitting patches as soon as you have _some_ patches
> ready. In other words, keep the delta between mainline and your
> not-yet-submitted patches as small as possible.
> 
> And the patches don't need to be bug free as you can always fix bugs
> later. Just mention in the commit logs that this is preparation for some
> new feature and not fully tested yet. We do that all the time, for
> example Intel's iwlwifi has support for hardware which have not reached
> customers yet.
> 

Thanks for your answer. I'll submit patches when the drivers are ready and
stable. I have another question about the rules of new files. If I want to
add some new files, could I send a big patch with all new files? Is there
any limit? 

Thanks
PK


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux