RE: Two rtlwifi drivers?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Monday, October 16, 2017 3:50 PM
> To: Pkshih
> Cc: Larry Finger; Kalle Valo; Dan Carpenter; 莊彥宣; Johannes Berg; Souptick Joarder;
> devel@xxxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: Re: Two rtlwifi drivers?
> 
> 
> > 4) As Kalle mentioned, rtlwifi contains many magic numbers, and I
> >    plan to fix them after rtl8723de and rtl8821ce. Because the drivers
> >    are developing, the changes will make us hard to integrate. However,
> >    I don't have plan to process the magic numbers in the module phydm,
> >    because the most of BB/RF registers contain many functions. And
> >    it doesn't have a register name but a bit field name instead.
> >    Our BB team guys say the use of enumeration or defined name will
> >    be unreadable, and the name is meaningless for most people.
> 
> Don't be so sure that names are "meaningless", there are people here
> that have been doing network drivers and development for longer than
> anyone else in the world.  It's best to at least name values, even if
> they do not seem to make sense, as that way the value can be tracked
> correctly, and possibly be understood later by someone else, or even
> you!
> 

Thanks for your help to resolve our questions.
I'll pass this point to the guys.

PK

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux