Re: [PATCH] staging: brcm80211: implementation of RFKILL functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 19, 2011 at 05:57:07PM +0100, Johannes Berg wrote:
> On Wed, 2011-01-19 at 08:35 -0800, Arend Van Spriel wrote:
> > Hi Greg,
> > 
> > It would seem to, but I am following guideline from Documentation/rfkill.txt, section 3. Kernel API:
> > ""
> > To create an rfkill driver, driver's Kconfig needs to have
> > 
> >         depends on RFKILL || !RFKILL
> > 
> > to ensure the driver cannot be built-in when rfkill is modular. The !RFKILL
> > case allows the driver to be built when rfkill is not configured, which which
> > case all rfkill API can still be used but will be provided by static inlines
> > which compile to almost nothing.
> > ""
> > 
> > I am not sure if this is really needed as cfg80211 does most of rfkill work for us.
> 
> It shouldn't be necessary, since you depend on cfg80211's API. However,
> since you depend on cfg80211 you have this effect anyway since cfg80211
> has this dependency.

Thanks for the clarification.

Arend, care to resend without this line in the Kconfig file?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux