Hello,
On Fri, Jan 14, 2011 at 12:14:54PM +1100, ahern.michael.t@xxxxxxxxx wrote:
> @@ -329,7 +332,7 @@ static struct serial_data serial_read(struct file *f, int timeout)
>
> length++;
> if (data < 0) {
> - printk("serial2002 error\n");
> + printk(KERN_ERR "serial2002 error\n");
better use pr_err
> break;
> } else if (data & 0x80) {
> result.value = (result.value << 7) | (data & 0x7f);
> @@ -402,7 +405,7 @@ static int serial_2002_open(struct comedi_device *dev)
> devpriv->tty = filp_open(port, O_RDWR, 0);
> if (IS_ERR(devpriv->tty)) {
> result = (int)PTR_ERR(devpriv->tty);
> - printk("serial_2002: file open error = %d\n", result);
> + printk(KERN_ERR "serial_2002: file open error = %d\n", result);
> } else {
> struct config_t {
>
> @@ -434,7 +437,7 @@ static int serial_2002_open(struct comedi_device *dev)
> }
>
> tty_setspeed(devpriv->tty, devpriv->speed);
> - poll_channel(devpriv->tty, 31); /* Start reading configuration */
> + poll_channel(devpriv->tty, 31); /* Start reading config */
> while (1) {
> struct serial_data data;
>
> @@ -451,23 +454,23 @@ static int serial_2002_open(struct comedi_device *dev)
> command = (data.value >> 8) & 0x3;
> switch (kind) {
> case 1:{
IMHO these braces can go away, too.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
