Indeed, sorry I missed that as well. So what should we make of that #ifdef? The code inside it doesn't compile (anymore? I didn't find any development history for that patch except the original mail), as there is no definition of struct submit_ctx in the headers (for other rtl drivers - 8188eu, 8723bs - that struct lives in include/rtw_xmit.h). Is a comparable header simply missing? Regards, Andreas On 08/29/17 16:42, Greg KH wrote: > On Tue, Aug 29, 2017 at 09:10:10AM -0500, Larry Finger wrote: >> On 08/29/2017 06:30 AM, Andreas Ziegler wrote: >>> The debugging output in deinit_priv is guarded by an #ifdef using >>> CONFIG_RTL_DEBUG. This symbol does not exist and should be >>> CONFIG_RTLWIFI_DEBUG instead. >>> >>> Signed-off-by: Andreas Ziegler <andreas.ziegler@xxxxxx> >> >> NACK. >> >> Yes, there is a problem; however, CONFIG_RTLWIFI_DEBUG is not the value that >> should be used. That one is reserved for the non-staging drivers in >> drivers/net/wireless/realtek/rtlwifi/. The correct symbol for r8822be is >> CONFIG_RTLWIFI_DEBUG_ST. > > Yeah, kbuild just blew up on this as well, I wonder why my local build > testing didn't see that :( > > Now dropped. > > greg k-h >
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
