Re: [greybus-dev] [PATCH v2] staging: greybus: loopback_test: fix comment style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Greg

On 03-07-17, 23:27, Aleksey Rybalkin wrote:
> According to checkpatch warning, block comments should align the * on
> each line. Also, preferred style for multi-line comments is starting the
> comment text after the second *.
> 
> Signed-off-by: Aleksey Rybalkin <aleksey@xxxxxxxxxxxx>
> ---
>  drivers/staging/greybus/tools/loopback_test.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index 32a43693181c..d86bcce53e6b 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t)
>  	tm = *localtime(&local_time);
>  
>  	/*
> -	* file name will test_name_size_iteration_max.csv
> -	* every time the same test with the same parameters is run we will then
> -	* append to the same CSV with datestamp - representing each test
> -	* dataset.
> -	*/
> +	 * file name will test_name_size_iteration_max.csv
> +	 * every time the same test with the same parameters is run we will then
> +	 * append to the same CSV with datestamp - representing each test
> +	 * dataset.
> +	 */
>  	if (t->file_output && !t->porcelain) {
>  		snprintf(file_name, sizeof(file_name), "%s_%d_%d.csv",
>  			t->test_name, t->size, t->iteration_max);
> @@ -779,7 +779,8 @@ static void prepare_devices(struct loopback_test *t)
>  {
>  	int i;
>  
> -	/* Cancel any running tests on enabled devices. If
> +	/*
> +	 * Cancel any running tests on enabled devices. If
>  	 * stop_all option is given, stop test on all devices.
>  	 */
>  	for (i = 0; i < t->device_count; i++)

Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux