Re: [greybus-dev] [PATCH] staging: greybus: loopback_test: fix comment style issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 30, 2017 at 09:43:44PM +0500, Aleksey Rybalkin wrote:
> According to checkpatch warning, block comments should align the * on
> each line.

How about "fixing" the other multi-line comment ("Cancel any
running..."), which isn't on the normal kernel format either while at
it?

	/*
	 * blah
	 */

You also forgot to CC the staging list (and the Greybus maintainers)
(see scripts/get_maintainer.pl).

Care to address that in a v2?

Thanks,
Johan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux