Re: [PATCH] linux-firmware: brcm: Removed codeversion from firmware filenames.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-10-21 at 10:08 -0700, Henry Ptasinski wrote:
> Here's a patch to rename our firmware files in the linux-firmware repo.  I'll
> be sending a complimentary patch to Greg for staging-next-2.6 shortly.
> 
> The basename-apiversion-codeversion construction for firmware filenames is not
> used by most other firmware files, adds complexity, and is not providing any
> value.  Rename the firmware files using just basename-apiversion. 

Please use the '-M' option to git diff (or whatever you're using) to
make it detect renames -- the resulting patch would be a lot shorter.

And also please ensure the filenames listed in the WHENCE file are all
correct. You don't seem to have fixed those to reflect your changes. And
in fact I think the WHENCE file is *already* listing the bcm4329 files
in the wrong directory?

-- 
dwmw2

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux