Re: [PATCH 2/4] staging: xgifb: Add compilation conditionals

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 04, 2010 at 07:07:48PM -0400, Javier Martinez Canillas wrote:
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@xxxxxxxxx>
> ---
>  drivers/staging/xgifb/XGI_main.h    |    2 ++
>  drivers/staging/xgifb/XGI_main_26.c |    6 ++++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h
> index 72448e8..93837f3 100644
> --- a/drivers/staging/xgifb/XGI_main.h
> +++ b/drivers/staging/xgifb/XGI_main.h
> @@ -345,7 +345,9 @@ static int XGIfb_userom = 0;
>  static int XGIfb_registered;
>  static int XGIfb_tvmode = 0;
>  static int XGIfb_mem = 0;
> +#ifndef MODULE
>  static int XGIfb_pdc = 0;
> +#endif

Ick, no, don't add conditionals, fix the code to not need such nonsense.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux