On Sat, Sep 04, 2010 at 07:06:47PM -0400, Javier Martinez Canillas wrote: > Hello, In today linux-next I got a some compile warnings with the staging/xgifb driver. This is the first of a 4 patchset that fix all the issues. > > The patches are: > > [PATCH 1/4] staging: xgifb: Fix compile warning > [PATCH 2/4] staging: xgifb: Add compilation conditionals > [PATCH 3/4] staging: xgifb: Removes unused variable > [PATCH 4/4] staging: xgifb: Init uninitialized variables and fix some style issues > > Thanks a lot. > > Signed-off-by: Javier Martinez Canillas <martinez.javier@xxxxxxxxx> > --- > drivers/staging/xgifb/XGI_main_26.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c > index 7cd3e95..3c80191 100644 > --- a/drivers/staging/xgifb/XGI_main_26.c > +++ b/drivers/staging/xgifb/XGI_main_26.c > @@ -3418,7 +3418,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev, > XGIfb_registered = 1; > > printk(KERN_INFO "XGIfb: Installed XGIFB_GET_INFO ioctl (%lx)\n", > - XGIFB_GET_INFO); > + (unsigned long)XGIFB_GET_INFO); No, you should use %p instead. Also, you don't spam the kernel log for assigning an ioctl function pointer, that's just looney... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
