Re: [patch] Staging: lirc: remove unneeded variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 11, 2010 at 10:46:47PM -0400, Jarod Wilson wrote:
> On Tue, Aug 10, 2010 at 08:11:20AM +0200, Dan Carpenter wrote:
> > We never use control_req so I removed it.
> > 
> > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> Leftover cruft from when lirc_imon also supported the devices now covered
> by the ir-core imon driver.
> 

Speak of left over stuff, it's weird that I didn't notice this before
but gcc complains about an unitialized variable in
imon_incoming_packet().

drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’:
drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used
	uninitialized in this function

I don't know how to fix that, but it looks important.

regards,
dan carpenter

> Acked-by: Jarod Wilson <jarod@xxxxxxxxxx>
> 
> 
> -- 
> Jarod Wilson
> jarod@xxxxxxxxxx
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux