On Wed, Jul 21, 2010 at 09:57:16AM +0200, Jiri Slaby wrote: > On 07/21/2010 02:57 AM, H Hartley Sweeten wrote: > > The ioctl's DT3155_STOP and DT3155_START are defined with the macro > > _IO indicating that they have no parameters. They should not be using > > copy_to_user to return data to user space. > > This is not a reason for removing them. You should check what real users > do/expect and base your reasoning on the top of that. > > So could you investigate that? I agree, we can't remove this, it changes the functionality of the kernel in a way that userspace might not be expecting. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel