Re: [PATCH] Staging: dt3155: Remove copy_to_user for ioctl's DT3155_{STOP|START}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/21/2010 02:57 AM, H Hartley Sweeten wrote:
> The ioctl's DT3155_STOP and DT3155_START are defined with the macro
> _IO indicating that they have no parameters. They should not be using
> copy_to_user to return data to user space.

This is not a reason for removing them. You should check what real users
do/expect and base your reasoning on the top of that.

So could you investigate that?

regards,
-- 
js
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux