On Thu, Jun 03, 2010 at 05:15:53PM +0800, Marek Lindner wrote: > On Thursday 03 June 2010 08:20:01 Joe Perches wrote: > > The patch changes the prefix from "batman-adv:" to "batman_adv: " > > so yes, it would break as-is. > > > > I think the concept is broken though, I believe dmesg output > > specifically is not guaranteed to remain stable, and batman should > > use some other, perhaps private, logger based on ethtool events. > > I think changing a dash to an underscore is not such a big deal (I did not > check the rest of the patch yet). But I'm interested to hear more about your > "private logger" idea because the current solution is far from being perfect. > As we have to debug the routing protocol every now and then it would be very > helpful to get direct access to some internal logging facility. In fact, that > existed before (inside of /proc) but was removed to be more compliant with the > linux kernel and the existing log facilities. You can always use debugfs if you like for something like this. Or tie into the profile/perf subsystem, that might be even easier. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
