Re: [PATCH] staging: b3dfg: endianess

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/22/2009 08:06 AM, Vasilis Liaskovitis wrote:
> I believe some endian conversions are needed for the card to work with big endian hosts. 
> Not tested, feedback kindly requested.

Hmm, b3dfg_read/write32 use ioread/write32 which do the conversion
automatically from/to LE if needed. Are you sure with that patch?

> --- linux-next.orig/drivers/staging/b3dfg/b3dfg.c	2009-09-22 00:50:40.000000000 -0500
> +++ linux-next/drivers/staging/b3dfg/b3dfg.c	2009-09-22 00:53:54.000000000 -0500
> @@ -214,7 +214,7 @@
>  					cpu_to_le32(frm_addr_dma));
>  	b3dfg_write32(fgdev, B3D_REG_EC220_TRF_SIZE,
>  					cpu_to_le32(frm_size >> 2));
> -	b3dfg_write32(fgdev, B3D_REG_EC220_DMA_STS, 0xf);
> +	b3dfg_write32(fgdev, B3D_REG_EC220_DMA_STS, cpu_to_le32(0xf));
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux