On Wed, Sep 16, 2009 at 12:49:09AM +0200, Pavel Machek wrote: > On Tue 2009-09-15 13:20:52, Greg KH wrote: > > On Tue, Sep 15, 2009 at 12:26:33PM -0700, Brian Swetland wrote: > > > On Tue, Sep 15, 2009 at 12:06 PM, Greg Kroah-Hartman <gregkh@xxxxxxx> wrote: > > > > From: Brian Swetland <swetland@xxxxxxxxxx> > > > > > > > > Infrastructure to support the Qualcomm "shared memory driver" > > > > interface, used to communicate with the baseband processor on MSM7k > > > > SoCs. The smd core provides low level facilities to interact with the > > > > shared memory comms region, and a "virtual serial channel" interface > > > > that higher level transports (AT command channel, rmnet virtual > > > > ethernet, qmi network management protocol, and oncrpc, for example) > > > > are routed over. > > > > > > > > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > Cc: Brian Swetland <swetland@xxxxxxxxxx> > > > > Cc: Iliyan Malchev <ibm@xxxxxxxxxxx> > > > > Cc: San Mehat <san@xxxxxxxxxxx> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > > > > --- > > > > drivers/staging/dream/smd/smd.c | 1330 +++++++++++++++++++++++++++++++ > > > > drivers/staging/dream/smd/smd_private.h | 171 ++++ > > > > drivers/staging/dream/smd/smd_qmi.c | 860 ++++++++++++++++++++ > > > > drivers/staging/dream/smd/smd_tty.c | 213 +++++ > > > > > > Minor nitpick, but the smd stuff is msm7k generic (applies to surf, > > > dream, magic, hero, etc). I still think the smd core *probably* > > > belongs under arch/arm/mach-msm in that it's pretty tightly fused to > > > the baseband side of the 7k/8k SoCs and not really useful external to > > > that. > > The goal is to put it into the mach-msm at the end... That would be good. > > Yeah, I'm not happy with the stuff under drivers/staging/dream/ right > > now at all. I'm wondering if I should just toss it all out andhave > > Pavel start over :( > > Juggling around 100K+ patches is not exactly fun&easy task, please > don't make do it again... Hey, I'm having to do this juggling now, it's either me or you :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel