Re: [PATCH 140/641] Staging: HTC Dream: add smd code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 15, 2009 at 12:26:33PM -0700, Brian Swetland wrote:
> On Tue, Sep 15, 2009 at 12:06 PM, Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
> > From: Brian Swetland <swetland@xxxxxxxxxx>
> >
> > Infrastructure to support the Qualcomm "shared memory driver"
> > interface, used to communicate with the baseband processor on MSM7k
> > SoCs.  The smd core provides low level facilities to interact with the
> > shared memory comms region, and a "virtual serial channel" interface
> > that higher level transports (AT command channel, rmnet virtual
> > ethernet, qmi network management protocol, and oncrpc, for example)
> > are routed over.
> >
> > Signed-off-by: Pavel Machek <pavel@xxxxxx>
> > Cc: Brian Swetland <swetland@xxxxxxxxxx>
> > Cc: Iliyan Malchev <ibm@xxxxxxxxxxx>
> > Cc: San Mehat <san@xxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> > ---
> >  drivers/staging/dream/smd/smd.c         | 1330 +++++++++++++++++++++++++++++++
> >  drivers/staging/dream/smd/smd_private.h |  171 ++++
> >  drivers/staging/dream/smd/smd_qmi.c     |  860 ++++++++++++++++++++
> >  drivers/staging/dream/smd/smd_tty.c     |  213 +++++
> 
> Minor nitpick, but the smd stuff is msm7k generic (applies to surf,
> dream, magic, hero, etc).  I still think the smd core *probably*
> belongs under arch/arm/mach-msm in that it's pretty tightly fused to
> the baseband side of the 7k/8k SoCs and not really useful external to
> that.

Yeah, I'm not happy with the stuff under drivers/staging/dream/ right
now at all.  I'm wondering if I should just toss it all out andhave
Pavel start over :(

Let me work through the patches he sent me to see if I can make
something out of it first though...

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux