On Mon, Jul 20, 2009 at 09:37:12PM +0200, Andi Kleen wrote: > Greg KH <gregkh at suse.de> writes: > > > > It's the "normal" way of cleaning up code. Start with a known-working > > piece of stuff, and incrementally clean it up. > > I have to agree with David. This is essentially unreviewable > in the original state. It would be good if you could > do all the obvious cleanups first and then post a consolidated > series. > > Most "obvious" cleanups should not change the binary, so > you can easily check they are correct by comparing the assembler > code. Unfortunatly, some of these cleanups do change the binary, as they are removing wrapper functions. Anyway, I agree, for a "proper" review, I will show the final, cleaned up version, like normal. But we aren't there just yet, that is why this code is going to live in the staging tree for a while. Give us some time to get it fixed up. thanks, greg k-h
