Hi all,
I pushed a few updates for firedtv (FireWire DVB driver) out to
git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git
and also to my quilt trees at
http://user.in-berlin.de/~s5r6/linux1394/firedtv/
Changes at linux1394-2.6.git:
- Renamed branch "firedtv" to "firedtv-2.6.25".
- Pushed some updates to branches firedtv-2.6.25, firedtv-2.6.27,
firedtv-2.6.28; see below.
- Created a new branch "firedtv" which is based on v2.6.29-rc2 and
does not share history with the other three branches. This was
necessary because a build bug was discovered; I folded the fix into
the respective commit.
Differences in the git history aside, the actual contents of the firedtv
sources are the same in all four branches. The firedtv branch is also
visible in Stephen Rothwell's linux-next.
Updates from this weekend:
- Finally renamed the files, variables, functions etc. from firesat to
firedtv.
- Folded four smaller source files into thematically related bigger files.
- Reduced stack usage in the AV/C code somewhat.
- Various stylistic changes.
See the log and diffstats of these changes further below.
I really need to get my act together and post the driver to LKML. :-)
In the coming week, I will look for remaining potential submission
hurdles and decide what I would want to tweak before I post everything.
As always, comments, criticism, and more so patches are welcome. :-)
Current total shortlog of v2.6.29-rc2..firedtv:
Ben Backx (2):
firesat: fix DVB-S2 device recognition
firesat: add DVB-S support for DVB-S2 devices
Greg Kroah-Hartman (1):
DVB: add firesat driver
Henrik Kurelid (5):
firesat: update isochronous interface, add CI support
firesat: avc resend
firedtv: fix returned struct for ca_info
firedtv: use length_field() of PMT as length
firedtv: fix registration - adapter number could only be zero
Julia Lawall (1):
firedtv: Use DEFINE_SPINLOCK
Rambaldi (2):
firedtv: rename files from firesat to firedtv
firedtv: rename variables and functions from firesat to firedtv
Stefan Richter (35):
firesat: add missing copyright notes
firesat: rename to firedtv
firedtv: nicer registration message and some initialization fixes
firedtv: some header cleanups
firedtv: replace semaphore by mutex
firedtv: move some code back to ieee1394 core
firedtv: replace tasklet by workqueue job
firedtv: fix remote control input
ieee1394: use correct barrier types between accesses of nodeid and generation
ieee1394: add hpsb_node_read() and hpsb_node_lock()
ieee1394: inherit ud vendor_id from node vendor_id
firedtv: use hpsb_node_read(), _write(), _lock()
firedtv: add vendor_id and version to driver match table
firedtv: remove unused dual subunit code from initialization
firedtv: fix initialization of dvb_frontend.ops
firedtv: remove unused struct members
firedtv: fix string comparison and a few sparse warnings
firedtv: register input device as child of a FireWire device
firedtv: remove various debug code
firedtv: remove AV/C debug code
firedtv: remove CA debug code
firedtv: trivial cleanups in firesat-ci
firedtv: trivial cleanups in cmp
firedtv: remove bitfield typedefs from cmp, fix for big endian CPUs
firedtv: don't retry oPCR updates endlessly
firedtv: trivial cleanups in avc_api
firedtv: trivial reorganization in avc_api
firedtv: replace mdelay by msleep
firedtv: increase FCP frame length for DVB-S2 tune QSPK
firedtv: iso: style changes and fixlets
firedtv: iso: remove unnecessary struct type definitions
firedtv: iso: move code to firedtv-1394
firedtv: cmp: move code to avc
firedtv: avc: reduce stack usage, remove two typedefs
firedtv: avc: fix offset in avc_tuner_get_ts
This weekend's updates:
commit 821f4f8a4f4ed89b1528d779d66b655830b29745
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: avc: fix offset in avc_tuner_get_ts
The parentheses were wrong. It didn't matter though because this code
only writes a 0 into an area which is already initialized to 0.
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/avc.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
commit a88d0bde0b594129325e36d569a0ddd07a307b4f
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: avc: reduce stack usage, remove two typedefs
It is safe to share a memory buffer for command frame and response frame
because the response data come in after the command frame was last used.
Even less stack would be required if only the actual required frame size
instead of the entire FCP register size was allocated.
Also, rename the defined types AVCCmdFrm and AVCRspFrm to
struct avc_command_frame and struct avc_response_frame.
TODO: Remove the bitfields in these types.
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/avc.c | 1074 +++++++++++++++++++-------------------
drivers/media/dvb/firewire/avc.h | 24 +-
2 files changed, 537 insertions(+), 561 deletions(-)
commit 3a134c9de70e69849bd68a666dddc2b236d94613
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: cmp: move code to avc
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/Makefile | 1 -
drivers/media/dvb/firewire/avc.c | 147 +++++++++++++++++++++++++
drivers/media/dvb/firewire/avc.h | 3 +
drivers/media/dvb/firewire/cmp.c | 171 -----------------------------
drivers/media/dvb/firewire/cmp.h | 9 --
drivers/media/dvb/firewire/firedtv-1394.c | 1 -
drivers/media/dvb/firewire/firedtv-fe.c | 1 -
7 files changed, 150 insertions(+), 183 deletions(-)
delete mode 100644 drivers/media/dvb/firewire/cmp.c
delete mode 100644 drivers/media/dvb/firewire/cmp.h
commit a05369ab518b125a7245aef8bc36c5f0aa6758f2
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: iso: move code to firedtv-1394
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/Makefile | 1 -
drivers/media/dvb/firewire/firedtv-1394.c | 96 ++++++++++++++++++++++++-
drivers/media/dvb/firewire/firedtv-iso.c | 110 -----------------------------
drivers/media/dvb/firewire/firedtv.h | 5 +-
4 files changed, 93 insertions(+), 119 deletions(-)
delete mode 100644 drivers/media/dvb/firewire/firedtv-iso.c
commit c6fbe78c68da195827f9d43cfd9e7279716b7c0e
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: iso: remove unnecessary struct type definitions
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/firedtv-iso.c | 17 ++++++++------
drivers/media/dvb/firewire/firedtv.h | 34 ------------------------------
2 files changed, 10 insertions(+), 41 deletions(-)
commit 915073a21f88b12bcbf43083db2bd73634d7c2cb
Author: Stefan Richter <stefanr at s5r6.in-berlin.de>
Date: Sun Jan 18 16:30:00 2009 +0100
firedtv: iso: style changes and fixlets
Add cleanup after failure in setup_iso_channel.
Replace printk() by dv_err().
Decrease indentation level in rawiso_activity_cb().
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/firedtv-iso.c | 136 ++++++++++++++---------------
1 files changed, 66 insertions(+), 70 deletions(-)
commit d9755c5d3906f116890ccc0d49c839c82806f66c
Author: Rambaldi <Rambaldi at xs4all.nl>
Date: Sat Jan 17 14:47:34 2009 +0100
firedtv: rename variables and functions from firesat to firedtv
Signed-off-by: Rambaldi <Rambaldi at xs4all.nl>
Additional changes by Stefan Richter:
Renamed struct firedtv *firedtv to struct firedtv *fdtv and
firedtv_foo_bar() to fdtv_foo_bar() for brevity.
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/firewire/avc.c | 188 ++++++++++++++--------------
drivers/media/dvb/firewire/avc.h | 34 +++---
drivers/media/dvb/firewire/cmp.c | 40 +++---
drivers/media/dvb/firewire/cmp.h | 6 +-
drivers/media/dvb/firewire/firedtv-1394.c | 186 ++++++++++++++--------------
drivers/media/dvb/firewire/firedtv-ci.c | 106 ++++++++--------
drivers/media/dvb/firewire/firedtv-ci.h | 6 +-
drivers/media/dvb/firewire/firedtv-dvb.c | 142 +++++++++++-----------
drivers/media/dvb/firewire/firedtv-fe.c | 122 +++++++++---------
drivers/media/dvb/firewire/firedtv-iso.c | 40 +++---
drivers/media/dvb/firewire/firedtv-rc.c | 18 ++--
drivers/media/dvb/firewire/firedtv-rc.h | 8 +-
drivers/media/dvb/firewire/firedtv.h | 32 +++---
13 files changed, 464 insertions(+), 464 deletions(-)
commit 090f9b5a193dc903ae2cd76a363f8e9c5fc1d9ed
Author: Rambaldi <Rambaldi at xs4all.nl>
Date: Sat Jan 17 13:07:44 2009 +0100
firedtv: rename files from firesat to firedtv
Signed-off-by: Rambaldi <Rambaldi at xs4all.nl>
Additional changes by Stefan Richter:
Name the directory "firewire" instead of "firedtv".
Standardize on "-" instead of "_" in file names, because that's what
drivers/firewire/ and drivers/media/dvb/dvb-usb/ use too.
Build fix.
Signed-off-by: Stefan Richter <stefanr at s5r6.in-berlin.de>
drivers/media/dvb/Kconfig | 2 +-
drivers/media/dvb/Makefile | 2 +-
drivers/media/dvb/{firesat => firewire}/Kconfig | 0
drivers/media/dvb/{firesat => firewire}/Makefile | 14 +++++++-------
.../dvb/{firesat/avc_api.c => firewire/avc.c} | 6 +++---
.../dvb/{firesat/avc_api.h => firewire/avc.h} | 0
drivers/media/dvb/{firesat => firewire}/cmp.c | 4 ++--
drivers/media/dvb/{firesat => firewire}/cmp.h | 0
.../firesat_1394.c => firewire/firedtv-1394.c} | 8 ++++----
.../firesat-ci.c => firewire/firedtv-ci.c} | 6 +++---
.../firesat-ci.h => firewire/firedtv-ci.h} | 0
.../firesat_dvb.c => firewire/firedtv-dvb.c} | 6 +++---
.../firesat_fe.c => firewire/firedtv-fe.c} | 4 ++--
.../firesat_iso.c => firewire/firedtv-iso.c} | 2 +-
.../firesat-rc.c => firewire/firedtv-rc.c} | 4 ++--
.../firesat-rc.h => firewire/firedtv-rc.h} | 0
.../dvb/{firesat/firesat.h => firewire/firedtv.h} | 6 +++---
17 files changed, 32 insertions(+), 32 deletions(-)
rename drivers/media/dvb/{firesat => firewire}/Kconfig (100%)
rename drivers/media/dvb/{firesat => firewire}/Makefile (50%)
rename drivers/media/dvb/{firesat/avc_api.c => firewire/avc.c} (99%)
rename drivers/media/dvb/{firesat/avc_api.h => firewire/avc.h} (100%)
rename drivers/media/dvb/{firesat => firewire}/cmp.c (99%)
rename drivers/media/dvb/{firesat => firewire}/cmp.h (100%)
rename drivers/media/dvb/{firesat/firesat_1394.c => firewire/firedtv-1394.c} (98%)
rename drivers/media/dvb/{firesat/firesat-ci.c => firewire/firedtv-ci.c} (98%)
rename drivers/media/dvb/{firesat/firesat-ci.h => firewire/firedtv-ci.h} (100%)
rename drivers/media/dvb/{firesat/firesat_dvb.c => firewire/firedtv-dvb.c} (99%)
rename drivers/media/dvb/{firesat/firesat_fe.c => firewire/firedtv-fe.c} (99%)
rename drivers/media/dvb/{firesat/firesat_iso.c => firewire/firedtv-iso.c} (99%)
rename drivers/media/dvb/{firesat/firesat-rc.c => firewire/firedtv-rc.c} (98%)
rename drivers/media/dvb/{firesat/firesat-rc.h => firewire/firedtv-rc.h} (100%)
rename drivers/media/dvb/{firesat/firesat.h => firewire/firedtv.h} (98%)
--
Stefan Richter
-=====-==--= ---= =--=-
http://arcgraph.de/sr/
