On Tue, Nov 20, 2007 at 04:07:44PM -0400, Felipe Balbi wrote: > On Nov 20, 2007 4:00 PM, Greg KH <greg at kroah.com> wrote: > > > > On Tue, Nov 20, 2007 at 04:24:26PM +0800, Peter Teoh wrote: > > > On Nov 20, 2007 12:31 PM, Greg KH <greg at kroah.com> wrote: > > > > > > > > Also, please run it through the scripts/checkpatch.pl script to fix all > > > > of the obvious coding style issues (no typedefs, line lengths, etc.) so > > > > it's in a format that we can be able to review it properly. > > > > > > > > thanks, > > > > > > > > > > Thank you for your reply. I will be getting the hardware to test > > > soon. But this is as per your instruction - thank you for the review > > > again. > > > > > /* > > > * USB loopback plug is based on the Cypress CY7C68013A USB2.0 chip > > so I'm the one wrong here, sorry. I thought this was meant to be a > kernel driver :-p No, this is a kernel driver, as written, so your comments are still correct :) My question is _why_ does it need to be a kernel driver, why can't this all be done in userspace instead? thanks, greg k-h
