On Nov 20, 2007 4:00 PM, Greg KH <greg at kroah.com> wrote: > > On Tue, Nov 20, 2007 at 04:24:26PM +0800, Peter Teoh wrote: > > On Nov 20, 2007 12:31 PM, Greg KH <greg at kroah.com> wrote: > > > > > > Also, please run it through the scripts/checkpatch.pl script to fix all > > > of the obvious coding style issues (no typedefs, line lengths, etc.) so > > > it's in a format that we can be able to review it properly. > > > > > > thanks, > > > > > > > Thank you for your reply. I will be getting the hardware to test > > soon. But this is as per your instruction - thank you for the review > > again. > > > /* > > * USB loopback plug is based on the Cypress CY7C68013A USB2.0 chip so I'm the one wrong here, sorry. I thought this was meant to be a kernel driver :-p forget about my comments. sorry again, Greg > > > I'm probably missing something here, but why does this need to be a > kernel driver at all? Can't this all work properly from userspace using > libusb or "raw" usbfs directly? > > confused, > > > greg k-h > _______________________________________________ > devel mailing list > devel at linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel > -- Best Regards, Felipe Balbi felipebalbi at users.sourceforge.net
