Jonathan Corbet <corbet@xxxxxxx> writes: > I've applied this, but... > > Yanteng Si <siyanteng@xxxxxxxxxxx> writes: > >> v3: >> >> * Pick Alex'S review-by tag. >> >> v2: >> >> Some bad translations have been modified as suggested by Alex.Thank you for your review. >> https://lore.kernel.org/linux-doc/CAEensMwq=i+nek6sNeqOJJMY648Q9ZF8cTKpXdJVuqdQQnMWUw@xxxxxxxxxxxxxx/T/#t >> >> v1: > > Text like the above belongs below the "---" line so I don't have to edit > it out of the changelog by hand. > >> This patch translates Documentation/core-api/workqueue.rst into Chinese. >> >> >> Signed-off-by: Yanteng Si <siyanteng@xxxxxxxxxxx> >> Reviewed-by: Alex Shi <alexs@xxxxxxxxxx> > > I fixed that typo too - it appears to originate from Alex...:) Actually, I've dropped this back out; it creates vast numbers of warnings: > Documentation/core-api/workqueue:398: ./include/linux/workqueue.h:3: WARNING: Duplicate C declaration, also > defined at translations/zh_CN/core-api/workqueue:3. This will be the result of the ".. kernel-doc::" directives at the end, which create new definitions (within sphinx) for all the symbols pulled in. In the long term, we may want to try to find some sort of fix for this. But we're really just recreating a bunch of (English-language) documentation that's already rendered once; I'm not sure it makes any real sense to do that. So I would suggest that, for now, when you are translating documents with kernel-doc directives, you should leave those directives out. Stick in a note directing readers to the original if they want to see that material... Make sense? Thanks, jon
