Re: [PATCH v3 01/14] intel_gna: add driver module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 13, 2021 at 01:00:27PM +0200, Maciej Kwapulinski wrote:
> +#ifdef CONFIG_DEBUG_INTEL_GNA
> +module_param(recovery_timeout, int, 0644);
> +MODULE_PARM_DESC(recovery_timeout, "Recovery timeout in seconds");
> +#endif

This is not the 1990's, please no new module parameters ever.  If you
only need this for "debugging" then use debugfs, that's exactly what it
is for.

But really, shouldn't this "just work" and not require someone to change
this by hand?

thanks,

greg k-h



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux