On Wed, Mar 3, 2021 at 5:38 PM Joe Stringer <joe@xxxxxxxxx> wrote:
>
> On Wed, Mar 3, 2021 at 12:29 PM Yonghong Song <yhs@xxxxxx> wrote:
> >
> >
> >
> > On 3/2/21 9:19 AM, Joe Stringer wrote:
> > > Based on a brief read of the corresponding source code.
> > >
> > > Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>
> > > Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>
> > > Signed-off-by: Joe Stringer <joe@xxxxxxxxx>
> >
> > Acked-by: Yonghong Song <yhs@xxxxxx>
> >
> > > ---
> > > include/uapi/linux/bpf.h | 14 +++++++++++---
> > > 1 file changed, 11 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> > > index a8f2964ec885..a6cd6650e23d 100644
> > > --- a/include/uapi/linux/bpf.h
> > > +++ b/include/uapi/linux/bpf.h
> > > @@ -306,14 +306,22 @@ union bpf_iter_link_info {
> > > *
> > > * BPF_PROG_TEST_RUN
> > > * Description
> > > - * Run an eBPF program a number of times against a provided
> > > - * program context and return the modified program context and
> > > - * duration of the test run.
> > > + * Run the eBPF program associated with the *prog_fd* a *repeat*
> > > + * number of times against a provided program context *ctx_in* and
> > > + * data *data_in*, and return the modified program context
> > > + * *ctx_out*, *data_out* (for example, packet data), result of the
> > > + * execution *retval*, and *duration* of the test run.
> >
> > FYI, Lorenz's BPF_PROG_TEST_RUN support for sk_lookup program
> > requires data_in and data_out to be NULL. Not sure whether it is
> > worthwhile to specially mention here or not. The patch has not
> > been merged but close.
> >
> > https://lore.kernel.org/bpf/20210301101859.46045-1-lmb@xxxxxxxxxxxxxx/
>
> Not sure how close either series is but I'm sure between Lorenz & I we
> can figure out how to fix this up. If I need to respin the series and
> Lorenz's one is in by then, I'll fix it up but it's not the end of the
> world to send an extra dedicated patch for this.
I sent this out:
https://lore.kernel.org/bpf/20210410174549.816482-1-joe@xxxxxxxxx/T/#u
