On Tue, Mar 16, 2021 at 03:13:06PM -0600, Alex Williamson wrote: > > > + void vfio_init_group_dev(struct vfio_device *device, > > > + struct device *dev, > > > + const struct vfio_device_ops *ops, > > > + void *device_data); > > > + int vfio_register_group_dev(struct vfio_device *device); > > > + void vfio_unregister_group_dev(struct vfio_device *device); > > > + > > > +The driver should embed the vfio_device in its own structure and call > > > +vfio_init_group_dev() to pre-configure it before going to registration. > > > > s/it/that structure/ (I guess?) > > Seems less clear actually, is the object of "that structure" the > "vfio_device" or "its own structure". Phrasing somewhat suggests the > latter. s/it/the vfio_device structure/ seems excessively verbose. I > think "it" is probably sufficient here. Thanks, Right, it says directly above that vfio_init_group_dev() accepts a vfio_device so I doubt anyone will be confused for long on what "it" refers to. I got the other language fixes thanks Jason
