Re: [PATCH v1 5/6] bio: add a helper calculating nr segments to alloc

To: Pavel Begunkov <asml.silence@xxxxxxxxx>
Subject: Re: [PATCH v1 5/6] bio: add a helper calculating nr segments to alloc
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 22 Dec 2020 14:07:49 +0000
Cc: linux-block@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "Darrick J . Wong" <darrick.wong@xxxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, io-uring@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx
In-reply-to: <94b6f76d2d47569742ee47caede1504926f9807a.1607976425.git.asml.silence@gmail.com>
References: <cover.1607976425.git.asml.silence@gmail.com> <94b6f76d2d47569742ee47caede1504926f9807a.1607976425.git.asml.silence@gmail.com>

The new helper needs a comment explaining the use case.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v1 0/6] no-copy bvec
  - From: Pavel Begunkov
- [PATCH v1 5/6] bio: add a helper calculating nr segments to alloc
  - From: Pavel Begunkov